fanotify backend #180
Open
fanotify backend #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
reviewed
Jun 20, 2024
src/linux/FAnotifyFsBackend.cc
Outdated
| #include "FAnotifyFsBackend.hh" | ||
|
|
||
| void FAnotifyFsBackend::start() { | ||
| throw std::runtime_error("not implemented"); |
There was a problem hiding this comment.
I don't know if we'd want to have an unimplemented backend here. And I'm unsure if we'd even end up implementing this one due to the elevated system permissions that it requires (CAP_SYS_ADMIN)
There was a problem hiding this comment.
fixed
'fanotify-fs' backend is completely removed from the code
|
@devongovett just gently checking in here. would love to get any initial thoughts on this when you have time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#87